Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

utils: remove lib/utils/rename.js #16204

Merged
merged 1 commit into from
Apr 4, 2017
Merged

utils: remove lib/utils/rename.js #16204

merged 1 commit into from
Apr 4, 2017

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Mar 30, 2017

It was used as a stub file to not break a monkey patching hack, but it's no longer required. It's removed with npm@5.

Fixes: #15965

@watilde
utils: remove lib/utils/rename.js
a7f59b0 
It was used as a stub file to not break a monkey patching hack,
but it's no longer required. It's removed with npm@5.

Fixes: npm#15965
@isaacs isaacs added the review label Mar 30, 2017
@iarna iarna added the breaking label Apr 3, 2017
@zkat zkat removed the review label Apr 4, 2017
@zkat zkat self-requested a review April 4, 2017 20:21
zkat
zkat approved these changes Apr 4, 2017
View reviewed changes
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zkat zkat changed the base branch from latest to release-next-5 April 4, 2017 20:21
@zkat zkat merged commit b1f6b87 into npm:release-next-5 Apr 4, 2017
@zkat
Copy link
Contributor

zkat commented Apr 4, 2017

...and into the integration branch it goes! Thanks!

@zkat zkat mentioned this pull request Apr 4, 2017
Closed
24 tasks
@watilde watilde deleted the feature/remove-rename-js branch April 5, 2017 02:06
iarna pushed a commit that referenced this pull request Apr 14, 2017
@watilde @iarna
utils: remove lib/utils/rename.js (#16204)
8bcef6a 
It was used as a stub file to not break a monkey patching hack,
but it's no longer required. It's removed with npm@5.

Fixes: #15965

PR-URL: #16204
Credit: @watilde 
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Apr 22, 2017
@watilde @zkat
utils: remove lib/utils/rename.js (#16204)
6c463be 
It was used as a stub file to not break a monkey patching hack,
but it's no longer required. It's removed with npm@5.

Fixes: #15965

PR-URL: #16204
Credit: @watilde 
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Apr 27, 2017
@watilde @zkat
utils: remove lib/utils/rename.js (#16204)
54b2ab5 
It was used as a stub file to not break a monkey patching hack,
but it's no longer required. It's removed with npm@5.

Fixes: #15965

PR-URL: #16204
Credit: @watilde 
Reviewed-By: @zkat
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zkat zkat zkat approved these changes

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@watilde @zkat @isaacs @iarna