Skip to content
This repository was archived by the owner on Aug 11, 2022. It is now read-only.

Replace cli.js with bin/npm-cli.js and remove cli.js #12096

Merged
merged 3 commits into from
Apr 4, 2017
Merged

Replace cli.js with bin/npm-cli.js and remove cli.js #12096

merged 3 commits into from
Apr 4, 2017

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Mar 27, 2016

The first of the cli.js was used for the bin field in package.json, but now it is used only by internal build codes. Also, some docs pointed it as an example instead of bin/npm-cli.js.

@zkat
Copy link
Contributor

zkat commented Mar 30, 2016

This looks fine to me. LGTM! Thanks, @watilde

Edit: After getting over my own brain haze, I realized this is very likely to be a semver-major change because we really don't know who might be relying on cli.js being there. It seems like a reasonable change to make -- but I (or whoever else does it) will most likely be picking it up with something like npm@4.

@zkat zkat added this to the next milestone Mar 30, 2016
@zkat zkat removed this from the next milestone Mar 31, 2016
@iarna iarna self-assigned this Apr 28, 2016
@watilde
Copy link
Contributor Author

watilde commented Oct 14, 2016

@iarna Hi! Was this patch added into v4, even this PR doesn't have the milestone?

@zkat zkat changed the base branch from master to release-next-5 April 4, 2017 20:17
@zkat zkat merged commit 4df3fa2 into npm:release-next-5 Apr 4, 2017
@zkat
Copy link
Contributor

zkat commented Apr 4, 2017

@watilde I started an npm@5 release branch for ongoing npm@5 work. This has been merged in. Thank you for your patience, and thank you for the patch and the helpful work, as always. <3

npm@5 will become latest sometime in the next month or two, hopefully. In the meantime, people can play with that branch. :)

@zkat zkat mentioned this pull request Apr 4, 2017
Closed
24 tasks
@watilde watilde deleted the patch/npm-cli-js branch April 5, 2017 00:14
iarna pushed a commit that referenced this pull request Apr 14, 2017
@watilde @iarna
cli: replace cli.js with bin/npm-cli.js and remove cli.js (#12096)
c25c6cc 
* scripts: replace cli.js with npm-cli.js

* cli: remove unused file cli.js

* docs: replace cli.js with bin/npm-cli.js

PR-URL: #12096
Credit: @watilde
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Apr 22, 2017
@watilde @zkat
cli: replace cli.js with bin/npm-cli.js and remove cli.js (#12096)
56631f4 
* scripts: replace cli.js with npm-cli.js

* cli: remove unused file cli.js

* docs: replace cli.js with bin/npm-cli.js

PR-URL: #12096
Credit: @watilde
Reviewed-By: @zkat
zkat pushed a commit that referenced this pull request Apr 27, 2017
@watilde @zkat
cli: replace cli.js with bin/npm-cli.js and remove cli.js (#12096)
ee23f43 
* scripts: replace cli.js with npm-cli.js

* cli: remove unused file cli.js

* docs: replace cli.js with bin/npm-cli.js

PR-URL: #12096
Credit: @watilde
Reviewed-By: @zkat
@shinnn shinnn mentioned this pull request May 25, 2017
Closed
@rmg rmg mentioned this pull request May 26, 2017
Closed
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@iarna iarna

Labels
breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@watilde @zkat @othiym23 @iarna