Skip to content

TSL: Use multi argument versions of min and max #31196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Conversation

kristiker
Copy link
Contributor

min and max support multiple arguments, so we can do this

- max( max( currentColor.r, currentColor.g ), currentColor.b )
+ max( currentColor.r, currentColor.g, currentColor.b )

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 337.26
78.64
337.26
78.64
+0 B
+0 B
WebGPU 553.48
153.41
553.47
153.41
-8 B
-2 B
WebGPU Nodes 552.83
153.26
552.82
153.26
-8 B
-2 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 468.44
113.28
468.44
113.28
+0 B
+0 B
WebGPU 628.43
170.1
628.43
170.1
+0 B
+0 B
WebGPU Nodes 583.28
159.44
583.28
159.44
+0 B
+0 B

@sunag sunag added this to the r177 milestone May 29, 2025
@mrdoob mrdoob merged commit 0d1e2d7 into mrdoob:dev May 30, 2025
12 checks passed
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
RuthySheffi pushed a commit to RuthySheffi/three.js that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants