WebGLBackend: Optimize vertex state definition. #30562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
These are screenshots from SpectorJS that show the WebGL state changes in the live example from #30560. Notice how the redundant
With this PR: 
|
Mugen87
commented
Feb 20, 2025
|
|
||
| if ( indexBuffer !== null ) { | ||
|
|
||
| gl.bindBuffer( gl.ELEMENT_ARRAY_BUFFER, indexBuffer ); |
There was a problem hiding this comment.
FYI: The index is no part of the VAO anymore similar to WebGLRenderer. If not doing this, there are scenarios where the index buffer is not correctly bound which results in a "no elements buffer bound" warning in WebGL. If that happens, the affected primitives won't render.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #30560
Description
While investigating #30560, I have noticed a lot of redundant vertex state definitions in the WebGL backend of
WebGPURenderer.VAOs and index buffers can be cached and
bindVertexArray()andbindBuffer()must only be executed if there is a state change.