Skip to content

Fix example selection in REPL #5653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix example selection in REPL #5653

merged 1 commit into from
Sep 18, 2024

Conversation

lukastaegert
Copy link
Member

prettier-plugin-organize-imports was removing the import without vue-tsc installed

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Via the introduction of prettier-plugin-organize-imports, an import in one of the REPL Vue files was removed that broke the example selection dropdown. This is fixed by also making vue-tsc a dependency. I hope at some time I will find some time to set up some E2E Tests for the REPL to avoid such things in the future...

@lukastaegert
Include examples in REPL again
5520ade 
prettier-plugin-organize-imports was removing the import without
vue-tsc installed
@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 4:33am

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 16, 2024 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-repl-examples

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-gfasfj116-rollup-js.vercel.app/repl/?pr=5653

@github-actions GitHub Actions
Copy link

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.395 ± 0.056 9.334 9.445 1.00
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.395 ± 0.039 9.359 9.435 1.00 ± 0.01

Internal benchmark

  • BUILD: 8368ms, 749 MB
    • initialize: 0ms, 26.1 MB
    • generate module graph: 3230ms, 575 MB
      • generate ast: 1533ms, 568 MB
    • sort and bind modules: 456ms, 620 MB
    • mark included statements: 4684ms, 749 MB
      • treeshaking pass 1: 1597ms, 716 MB
      • treeshaking pass 2: 767ms, 742 MB
      • treeshaking pass 3: 303ms, 745 MB
      • treeshaking pass 4: 277ms, 744 MB
      • treeshaking pass 5: 323ms, 748 MB
      • treeshaking pass 6: 266ms, 753 MB
      • treeshaking pass 7: 247ms, 753 MB
      • treeshaking pass 8: 240ms, 756 MB
      • treeshaking pass 9: 217ms, 754 MB
      • treeshaking pass 10: 219ms, 752 MB
      • treeshaking pass 11: 216ms, 749 MB
  • GENERATE: 922ms, 1.02 GB
    • initialize render: 0ms, 914 MB
    • generate chunks: 90ms, 917 MB
      • optimize chunks: 0ms, 918 MB
    • render chunks: 810ms, 1 GB
    • transform chunks: 19ms, 1.02 GB
    • generate bundle: 0ms, 1.02 GB

@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (da0e5f7) to head (5520ade).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #5653   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         242      242           
  Lines        9345     9345           
  Branches     2470     2470           
=======================================
  Hits         9288     9288           
  Misses         48       48           
  Partials        9        9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert lukastaegert merged commit bd735b6 into master Sep 18, 2024
39 checks passed
@lukastaegert lukastaegert deleted the fix-repl-examples branch September 18, 2024 05:29
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.22.0. You can test it via npm install rollup.

Ydoug36
Ydoug36 reviewed Oct 11, 2024
View reviewed changes
Copy link

@Ydoug36 Ydoug36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix-repl-examples

This was referenced Oct 13, 2024
Open
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ydoug36 Ydoug36 Ydoug36 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukastaegert @Ydoug36