Skip to content

Partially revert #5658 and re-apply #5644 #5667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Partially revert #5658 and re-apply #5644 #5667

merged 1 commit into from
Sep 20, 2024

Conversation

lukastaegert
Copy link
Member

It appears that this might cause some build failures that need further investigation.

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Apparently, the previous change caused bigger issues that need investigation.

It appears that this might cause some build failures
that need further investigation.
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 9:18am

Copy link

github-actions bot commented Sep 20, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#revert

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-q2lwyz028-rollup-js.vercel.app/repl/?pr=5667

@lukastaegert lukastaegert merged commit d5ff63d into master Sep 20, 2024
25 checks passed
@lukastaegert lukastaegert deleted the revert branch September 20, 2024 09:20
Copy link

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.265 ± 0.069 9.203 9.339 1.01 ± 0.01
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.196 ± 0.066 9.147 9.271 1.00

Internal benchmark

  • BUILD: 8232ms, 750 MB
    • initialize: 0ms, 26 MB
    • generate module graph: 3179ms, 575 MB
      • generate ast: 1566ms, 568 MB
    • sort and bind modules: 449ms, 617 MB
    • mark included statements: 4609ms, 750 MB
      • treeshaking pass 1: 1581ms, 717 MB
      • treeshaking pass 2: 748ms, 743 MB
      • treeshaking pass 3: 296ms, 746 MB
      • treeshaking pass 4: 272ms, 745 MB
      • treeshaking pass 5: 314ms, 749 MB
      • treeshaking pass 6: 260ms, 754 MB
      • treeshaking pass 7: 242ms, 754 MB
      • treeshaking pass 8: 234ms, 752 MB
      • treeshaking pass 9: 213ms, 756 MB
      • treeshaking pass 10: 214ms, 753 MB
      • treeshaking pass 11: 214ms, 750 MB
  • GENERATE: 895ms, 1.02 GB
    • initialize render: 0ms, 915 MB
    • generate chunks: 89ms, 921 MB
      • optimize chunks: 0ms, 917 MB
    • render chunks: 782ms, 1 GB
    • transform chunks: 19ms, 1.02 GB
    • generate bundle: 0ms, 1.02 GB

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (0a821d9) to head (0cd259e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5667      +/-   ##
==========================================
- Coverage   99.39%   99.39%   -0.01%     
==========================================
  Files         242      242              
  Lines        9348     9346       -2     
  Branches     2470     2470              
==========================================
- Hits         9291     9289       -2     
  Misses         48       48              
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This PR has been released as part of rollup@4.22.2. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant