-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Partially revert #5658 and re-apply #5644 #5667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It appears that this might cause some build failures that need further investigation.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#revert Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report!Rough benchmark
Internal benchmark
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5667 +/- ##
==========================================
- Coverage 99.39% 99.39% -0.01%
==========================================
Files 242 242
Lines 9348 9346 -2
Branches 2470 2470
==========================================
- Hits 9291 9289 -2
Misses 48 48
Partials 9 9 ☔ View full report in Codecov by Sentry. |
This PR has been released as part of rollup@4.22.2. You can test it via |
It appears that this might cause some build failures that need further investigation.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
moduleSideEffects: false
removes side effectful getter inside a exported function since 4.9.2 #5408Description
Apparently, the previous change caused bigger issues that need investigation.