Change npm_config_node_gyp to use shell script on Windows
#14568
Conversation
On non-Windows platforms, custom node-gyp can be used by npm by `export npm_config_node_gyp=$(which node-gyp)`. But on Windows, the implementation expected the real js script of node-gyp rather than the shell script. So you have to set the environment to `path\to\global\node_modules\node-gyp\bin\node-gyp.js`. This patch changed the launch script of node-gyp by invoking the script set to `npm_config_node_gyp` directly instead of invoking as node script. Fixed npm#14543
|
I think this should be discussed, because people might want to use the |
|
Not familiar with this. I'll leave it to @othiym23 :) |
|
See #8324 (and also 9bcf573) for details around the last time we changed this – this points to a couple holes around npm's Windows behavior and testing:
Since #8324 exists, and now this PR also exists, we need to come to a consensus about what the actual desired behavior is. @zkat suggested adding an additional configuration parameter to choose whether to invoke Either way, this is something where the change is small but the additional testing and validation that we're making the right change is large. Sorry for dumping a bunch of extra work in your lap to get this change landed, but thanks for the time you've put into it thus far! |
|
This still needs tests and as it's been over six months, I'm going to close this. If you do come back to work on it, please feel free to open a new pull request. |
On non-Windows platforms, custom node-gyp can be used by npm by
export npm_config_node_gyp=$(which node-gyp). But on Windows,the implementation expected the real js script of node-gyp rather
than the shell script. So you have to set the environment to
path\to\global\node_modules\node-gyp\bin\node-gyp.js. This patchchanged the launch script of node-gyp by invoking the script set
to
npm_config_node_gypdirectly instead of invoking as node script.Fixed #14543