WebGLRenderer: Enable half float attributes. #20587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Um, |
|
Hmm, so |
|
Yes. But I was hoping that at some point |
|
Indeed... |
|
Thanks! |
We can now! https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Float16Array |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
Fixed #15480.
Description
The PR introduces
Float16BufferAttributeso the renderer can detect half float buffer attribute data and correctly set thegl.HALF_FLOATtype. The change does not contain automatic data conversion for now. I've realized this would cause more changes inWebGLAttributessince you have to support the initial buffer upload as well as buffer updates. So the app has to perform the conversion viaDataUtils.toHalfFloat()for now. Support for automatic conversion can be added later if it turns out to be a dev pain.